Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490269 --- Comment #9 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-04-13 10:56:44 EDT --- xfglenses.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 10) 3 packages and 0 specfiles checked; 0 errors, 1 warnings. - You didn't update release tag, even though you modified the spec file. - Fix the rpmlint warning. Also, please don't use macros where they are not needed: rm, make, cp, mkdir &c. This makes the spec file unneededly difficult to read. - Vendor is incorrect, should be empty string "". If you're targeting solely for Fedora, it isn't even needed (EPEL still needs the explicit vendor argument). - Patch0 is highly dubitable since it is not necessary in order to build the package; it just modifies the credits of the program. Given that it's the only patch that is supplied and it does not modify the program in any way, I find it impossible to accept as such. If you have contributed to the package, the modifications should be put in by upstream. ** rpmlint output: MUST: The spec file for the package is legible and macros are used consistently. NEEDSFIX MUST: A package must own all directories that it creates or require the package that owns the directory. NEEDSFIX - Add Requires: hicolor-icon-theme -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review