Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492520 --- Comment #2 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-04-12 20:08:16 EDT --- Thanks for the review! Sorry I was very busy earlier today. (In reply to comment #1) > > * MUST: The package must meet the Packaging Guidelines > NOT O.K. // NOT SURE > missing Requirement(s): hicolor-icon-theme > missing Requirement(s) postun: desktop-file-utils shared-mime-info > missing Requirement(s) post: desktop-file-utils shared-mime-info > > .:[ cassmodiah @ schafwiese : /home/cassmodiah ]:. > $ rpm -qf /usr/bin/update-desktop-database && rpm -qf > /usr/bin/update-mime-database > desktop-file-utils-0.15-3.fc10.i386 > shared-mime-info-0.51-5.fc10.i386 > Here is a dependency chain to hicolor-icon-theme. There might be even more ways of getting down there. swami -> fluidsynth-libs -> lash -> gtk2 -> hicolor-icon-theme All are solid dependencies and I doubt that they will break in the foreseeable future. So we don't really need R: hicolor-icon-theme, but I'm adding it anyways. As for post(un): desktop-file-utils shared-mime-info, have a look at http://fedoraproject.org/wiki/Packaging/ScriptletSnippets Especially, in the notes of the desktop-database, mimeinfo and icon cache sections, they explictly say that "Note that no dependencies should be added for this." etc Here is an update: Spec URL: http://oget.fedorapeople.org/review/swami.spec SRPM URL: http://oget.fedorapeople.org/review/swami-0.9.4-4.fc10.src.rpm Changelog: 0.9.4-4 - Add Requires: hicolor-icon-theme -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review