[Bug 492520] Review Request: swami - MIDI instrument and sound editor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492520


Simon Wesp <cassmodiah@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #1 from Simon Wesp <cassmodiah@xxxxxxxxxxxxxxxxx>  2009-04-12 16:25:13 EDT ---
-= Review swami =-

* MUST: rpmlint must be run on every package. The output should be posted in
the review.
O.K.
rpmlint is silent


* MUST: The package must be named according to the Package Naming Guidelines
O.K.


* MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
O.K.


* MUST: The package must meet the Packaging Guidelines
NOT O.K. // NOT SURE
missing Requirement(s): hicolor-icon-theme
missing Requirement(s) postun: desktop-file-utils shared-mime-info
missing Requirement(s) post: desktop-file-utils shared-mime-info

.:[ cassmodiah @ schafwiese : /home/cassmodiah ]:.
$ rpm -qf /usr/bin/update-desktop-database && rpm -qf
/usr/bin/update-mime-database
desktop-file-utils-0.15-3.fc10.i386 
shared-mime-info-0.51-5.fc10.i386



* MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines
O.K.


* MUST: The License field in the package spec file must match the actual
license.
O.K.


* MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
O.K.


* MUST: The spec file must be written in American English.
O.K.


* MUST: The spec file for the package MUST be legible.
O.K.


* MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
O.K.
my dl: 83da8e71ce1e6cda0f41d9f5e0ed3fdf 
package: 83da8e71ce1e6cda0f41d9f5e0ed3fdf 


* MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
O.K. i386


* MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
N/A


* MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
O.K.
Hint (automake can removed from BuildRequires, because it is a dependency):
================================================================================
Package              Arch   Version                     Repository        Size
================================================================================
Installing:
ImageMagick          i386   6.4.0.10-2.fc10             fedora           5.6 M
audiofile-devel      i386   1:0.2.6-9.fc10              fedora            16 k
autoconf             noarch 2.63-1.fc10                 fedora           937 k
ccache               i386   2.4-13.fc9                  fedora            52 k
desktop-file-utils   i386   0.15-3.fc10                 fedora            60 k
fluidsynth-devel     i386   1.0.8-2.fc10                fedora           307 k
gnome-libs-devel     i386   1:1.4.2-10.fc10             fedora           500 k
libpng-devel         i386   2:1.2.35-1.fc10             updates-released 108 k
libsndfile-devel     i386   1.0.17-6.fc10               fedora           241 k
libtool              i386   1.5.26-4.fc10               fedora           694 k
popt-devel           i386   1.13-4.fc10                 fedora           393 k
================================================================================
Installing for dependencies:
GConf2               i386   2.24.0-1.fc10               fedora           1.7 M
ORBit                i386   1:0.5.17-23.fc9             fedora           350 k
ORBit-devel          i386   1:0.5.17-23.fc9             fedora           197 k
ORBit2               i386   2.14.16-1.fc10              fedora           184 k
PolicyKit            i386   0.9-4.fc10                  updates-released 168 k
alsa-lib             i386   1.0.19-2.fc10               updates-released 411 k
alsa-lib-devel       i386   1.0.19-2.fc10               updates-released 997 k
atk                  i386   1.24.0-1.fc10               fedora           214 k
audiofile            i386   1:0.2.6-9.fc10              fedora           103 k
automake             noarch 1.10.1-2                    fedora           532 k
cairo                i386   1.8.0-1.fc10                fedora           443 k
cups-libs            i386   1:1.3.9-8.fc10              updates-released 203 k
dbus-glib            i386   0.76-3.fc10                 fedora           170 k
esound-devel         i386   1:0.2.41-1.fc10             updates-released  18 k
esound-libs          i386   1:0.2.41-1.fc10             updates-released  78 k
flac                 i386   1.2.1-4.fc9                 fedora           307 k
fluidsynth-libs      i386   1.0.8-2.fc10                fedora           490 k
fontconfig           i386   2.6.0-3.fc10                fedora           182 k
freetype             i386   2.3.7-2.fc10                updates-released 356 k
ghostscript          i386   8.63-5.fc10                 updates-released 6.6 M
ghostscript-fonts    noarch 5.50-19.fc10                fedora           812 k
giflib               i386   4.1.3-9                     fedora            39 k
giflib-devel         i386   4.1.3-9                     fedora           107 k
glib                 i386   1:1.2.10-30.fc10            fedora           139 k
glib-devel           i386   1:1.2.10-30.fc10            fedora            39 k
gnome-libs           i386   1:1.4.2-10.fc10             fedora           1.1 M
gnutls               i386   2.4.2-3.fc10                updates-released 388 k
gtk+                 i386   1:1.2.10-66.fc10            fedora           918 k
gtk+-devel           i386   1:1.2.10-66.fc10            fedora           355 k
gtk2                 i386   2.14.7-7.fc10               updates-released 4.3 M
hicolor-icon-theme   noarch 0.10-4                      fedora            39 k
imlib                i386   1:1.9.15-9.fc10             fedora           420 k
imlib-devel          i386   1:1.9.15-9.fc10             fedora           110 k
indent               i386   2.2.10-2.fc10               fedora           115 k
jack-audio-connection-kit
                     i386   0.116.1-3.fc10              updates-released 203 k
jasper-libs          i386   1.900.1-9.fc10              updates-released 153 k
lash                 i386   0.5.4-2.fc9                 fedora           158 k
lcms-libs            i386   1.18-1.fc10                 updates-released 109 k
libICE               i386   1.0.4-4.fc10                fedora            54 k
libICE-devel         i386   1.0.4-4.fc10                fedora            13 k
libIDL               i386   0.8.11-1.fc10               fedora            88 k
libSM                i386   1.1.0-2.fc10                fedora            26 k
libSM-devel          i386   1.1.0-2.fc10                fedora            10 k
libX11               i386   1.1.5-2.fc10                updates-released 830 k
libX11-devel         i386   1.1.5-2.fc10                updates-released 1.1 M
libXau               i386   1.0.4-1.fc10                fedora            20 k
libXau-devel         i386   1.0.4-1.fc10                fedora            11 k
libXcomposite        i386   0.4.0-5.fc10                fedora            14 k
libXcursor           i386   1.1.9-3.fc10                fedora            29 k
libXdamage           i386   1.1.1-4.fc9                 fedora            11 k
libXdmcp             i386   1.0.2-6.fc10                fedora            21 k
libXdmcp-devel       i386   1.0.2-6.fc10                fedora           8.0 k
libXext              i386   1.0.4-1.fc9                 fedora            38 k
libXext-devel        i386   1.0.4-1.fc9                 fedora            60 k
libXfixes            i386   4.0.3-4.fc10                fedora            14 k
libXfont             i386   1.3.3-1.fc10                fedora           226 k
libXft               i386   2.1.13-1.fc10               fedora            50 k
libXi                i386   1.1.3-4.fc9                 fedora            28 k
libXi-devel          i386   1.1.3-4.fc9                 fedora            52 k
libXinerama          i386   1.0.3-2.fc10                fedora            13 k
libXpm               i386   3.5.7-4.fc9                 fedora            56 k
libXrandr            i386   1.2.3-1.fc10                fedora            26 k
libXrender           i386   0.9.4-3.fc9                 fedora            28 k
libXt                i386   1.0.5-1.fc10                fedora           178 k
libXt-devel          i386   1.0.5-1.fc10                fedora           328 k
libXxf86vm           i386   1.0.2-1.fc10                fedora            17 k
libavc1394           i386   0.5.3-4.fc10                fedora            46 k
libcroco             i386   0.6.1-5.fc9                 fedora           109 k
libdrm               i386   2.4.0-0.21.fc10             fedora            41 k
libfontenc           i386   1.0.4-6.fc10                fedora            23 k
libfreebob           i386   1.0.11-3.fc10               fedora           160 k
libgcrypt            i386   1.4.4-1.fc10                updates-released 237 k
libgpg-error         i386   1.6-2                       fedora            65 k
libgsf               i386   1.14.10-1.fc10              fedora           124 k
libiec61883          i386   1.2.0-1.fc10                updates-released  37 k
libjpeg              i386   6b-43.fc10                  fedora           144 k
libjpeg-devel        i386   6b-43.fc10                  fedora           104 k
libogg               i386   2:1.1.3-9.fc9               fedora            20 k
libpng               i386   2:1.2.35-1.fc10             updates-released 252 k
libpng10             i386   1.0.43-1.fc10               updates-released 129 k
libraw1394           i386   2.0.1-1.fc10                updates-released  58 k
librsvg2             i386   2.22.3-1.fc10               fedora           152 k
libsndfile           i386   1.0.17-6.fc10               fedora           235 k
libtasn1             i386   1.5-1.fc10                  fedora           294 k
libthai              i386   0.1.9-4.fc9                 fedora           187 k
libtiff              i386   3.8.2-11.fc10               fedora           310 k
libtiff-devel        i386   3.8.2-11.fc10               fedora           465 k
libtool-ltdl         i386   1.5.26-4.fc10               fedora            40 k
libutempter          i386   1.1.5-2.fc9                 fedora            22 k
libwmf-lite          i386   0.2.8.4-18.fc9              fedora            53 k
libxcb               i386   1.1.91-5.fc10               fedora           124 k
libxcb-devel         i386   1.1.91-5.fc10               fedora           144 k
libxml2              i386   2.7.3-1.fc10                updates-released 859 k
m4                   i386   1.4.11-1.fc10               fedora           225 k
mesa-dri-drivers     i386   7.2-0.15.fc10               updates-released 2.0 M
mesa-libGL           i386   7.2-0.15.fc10               updates-released 167 k
mesa-libGL-devel     i386   7.2-0.15.fc10               updates-released 460 k
pango                i386   1.22.3-1.fc10               updates-released 375 k
pixman               i386   0.12.0-2.fc10               fedora           117 k
pkgconfig            i386   1:0.23-6.fc10               updates-released  69 k
urw-fonts            noarch 2.4-6.fc10                  fedora           3.2 M
xdg-utils            noarch 1.0.2-5.20081121cvs.fc10    updates-released  52 k
xorg-x11-filesystem  noarch 7.3-2.fc10                  fedora           5.6 k
xorg-x11-font-utils  i386   1:7.2-6.fc10                fedora            76 k
xorg-x11-proto-devel noarch 7.4-5.fc10                  updates-released 278 k
zlib-devel           i386   1.2.3-18.fc9                fedora            42 k
================================================================================


* MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
N/A


* MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
N/A


* MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. 
N/A


* MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. 
O.K.

* MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. 
O.K.


* MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. 
O.K.


* MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT). 
O.K.


* MUST: Each package must consistently use macros. 
O.K.
you:
Source0:       
http://downloads.sourceforge.net/swami/%{name}-%{version}.tar.bz2
me:
Source0:       
http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.bz2


* MUST: The package must contain code, or permissable content. 
O.K.


* MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). 
N/A


* MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. 
O.K.


* MUST: Header files must be in a -devel package.
N/A


* MUST: Static libraries must be in a -static package.
N/A


* MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
N/A


* MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
N/A


* MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} 
N/A


* MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
O.K.


* MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation. 
O.K.


* MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time. 
O.K.


* MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). 
O.K.


* MUST: All filenames in rpm packages must be valid UTF-8.
O.K.


* SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
N/A


* SHOULD: The description and summary sections in the package spec file should
contain translations for supported Non-English languages, if available.
N/A


* SHOULD: The reviewer should test that the package builds in mock.
O.K.


* SHOULD: The package should compile and build into binary rpms on all
supported architectures. 
O.K.


* SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.
NOT O.K.


* SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague,
and left up to the reviewers judgement to determine sanity. 
O.K.


* SHOULD: Usually, subpackages other than devel should require the base package
using a fully versioned dependency.
N/A


* SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and
this is usually for development purposes, so should be placed in a -devel pkg.
A reasonable exception is that the main pkg itself is a devel tool not
installed in a user runtime, e.g. gcc or gdb. 
N/A


* SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself. 
N/A

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]