Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489728 --- Comment #5 from Alexey Torkhov <atorkhov@xxxxxxxxx> 2009-04-08 18:49:47 EDT --- (In reply to comment #4) > Note that it's a practice review, I need to do some in order to get a > sponsoring. Great, thanks for comments! > * Architecture Support: DON'T KNOW (try a koji scratchbuild, I don't have a > sponsor yet, so I can't test it for you) Here is the koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1286188 > * Filesystem layout: not-OK > - Locale files in %{_datadir}/%{name} - are you sure it's the best place? Those are QT locales, they are usually being put in program's share dir, as done here by upstream. > * Compiler flags: not-OK > - Consider using %cmake macro (see: > http://fedoraproject.org/wiki/Packaging/cmake ) This is qmake, not cmake. > * Desktop files: OK > - add: GenericName[pl]=Warcaby and Comment[pl]=Klasyczna gra planszowa - > warcaby Game itself doesn't have Polish locale. Will think about adding this. > * Build packages with separate user accounts: not-OK ;) Um, why not OK? > * All patches should have an upstream bug link or comment: not-OK > - The Patch1 should probably be sent back to upstream. Second patch is committed into upstream CVS two year ago. Will add comments for patches in next package revision. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review