Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489728 Marcin Łabanowski <chax@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chax@xxxxxxxxx --- Comment #4 from Marcin Łabanowski <chax@xxxxxxxxx> 2009-04-08 16:28:39 EDT --- Note that it's a practice review, I need to do some in order to get a sponsoring. * Naming: OK * Version and release: OK * Legal: OK * No inclusion of pre-built binaries or libraries: OK * Spec Legibility: OK * Writing a package from scratch: OK * Modifying an existing package: N/A * Architecture Support: DON'T KNOW (try a koji scratchbuild, I don't have a sponsor yet, so I can't test it for you) * Filesystem layout: not-OK - Locale files in %{_datadir}/%{name} - are you sure it's the best place? * Use rpmlint: OK * Changelogs: OK * Tags: OK * BuildRoot tag: OK * Requires: OK * BuildRequires: OK, mockbuild was successful - I would rather suggest keeping qt4-devel in order to stay compatible with F8, even though it is not supported anymore. * Summary and description: OK * Encoding: OK * Documentation: OK * Compiler flags: not-OK - Consider using %cmake macro (see: http://fedoraproject.org/wiki/Packaging/cmake ) * Debuginfo packages: OK * Devel packages: N/A * Requiring Base Package: N/A * Shared Libraries: N/A * Packaging Static Libraries: N/A * Duplication of system libraries: OK * Beware of Rpath: OK * Configuration files: N/A * Initscripts: N/A * Desktop files: OK - add: GenericName[pl]=Warcaby and Comment[pl]=Klasyczna gra planszowa - warcaby * Macros: OK, but see my comment for compiler flags * Handling Locale Files: OK, but see my comment for filesystem layout * Timestamps: OK * Parallel make: OK * Scriptlets: OK * Conditional dependencies: N/A * Build packages with separate user accounts: not-OK ;) * Relocatable packages: OK * Code Vs Content: OK * File and Directory Ownership: OK * Users and Groups: N/A * Web Applications: N/A * Conflicts: OK * No External Kernel Modules: OK * No Files or Directories under /srv: OK * Bundling of multiple projects: OK * All patches should have an upstream bug link or comment: not-OK - The Patch0 is Fedora-specific, but it doesn't say so. There is no description of it neither. - The Patch1 should probably be sent back to upstream. * Application Specific Guidelines: N/A -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review