Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493957 --- Comment #5 from Lubomir Rintel <lkundrak@xxxxx> 2009-04-05 06:18:02 EDT --- Thanks for the review. (In reply to comment #3) > - You didn't try to build in mock, did you? Missing BRs: > BuildRequires: desktop-file-utils > BuildRequires: libQGLViewer-devel > BuildRequires: qt4-devel Nope, dependencies weren't in yet, and I did not bother constructing repositories. Thanks for that. Will fix. (Will reroll the package once the license is settled) > MUST: The package must be licensed with a Fedora approved license and meet the > Licensing Guidelines. NEEDSFIX > MUST: The License field in the package spec file must match the actual license. > NEEDSFIX > - There is no license file included, or any license mentioned in the source > code or the homepage. Must get license information from upstream before the > package can be approved. Trying to do that. Contacted via a web form a week ago, no response. Sent mail to the authors now. > SHOULD: If the package does not include license text(s) as separate files from > upstream, the packager should query upstream to include it. NEEDSFIX Done. > MUST: All relevant items are included in %doc. Items in %doc do not affect > runtime of application. NEEDSFIX > - Add general.txt and notes-ngp.txt (In reply to comment #4) > Also, IIUC there is documentation that can be generated using doxygen, please > have a look if you can get it to build. I'm not going to do this. This is a software package, not a substitution for developer's infrastructure. If upstream wanted me to do this, they would integrate it in the build system. I doubt anyone will miss it anyways. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review