Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226483 --- Comment #4 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-04-05 05:22:03 EDT --- - The patches are not commented. Comments should be added why any specific patch is needed. - A newer version 6.16 has been released in September. - Requires(post): grep and Requires(postun): coreutils, grep are a bit silly, aren't these already required by some minimal system rpm? - Is the autoreconf really necessary? - Drop the buildroot checks [ -n "$RPM_BUILD_ROOT" -a "$RPM_BUILD_ROOT" != / ] in install and clean phase. - Consider safening the %post and %postun phases with %post if [ ! -f /etc/shells ]; then echo "%{_bindir}/tcsh" >> /etc/shells echo "%{_bindir}/csh" >> /etc/shells else grep -q '^%{_bindir}/tcsh$' /etc/shells || \ echo "%{_bindir}/tcsh" >> /etc/shells grep -q '^%{_bindir}/csh$' /etc/shells || \ echo "%{_bindir}/csh" >> /etc/shells fi %postun if [ ! -x %{_bindir}/tcsh ]; then grep -v '^%{_bindir}/tcsh$' /etc/shells | \ grep -v '^%{_bindir}/csh$' > /etc/shells.rpm && mv /etc/shells.rpm /etc/shells fi - Package does not handle locales in the right manner. Installing manually is OK, but after that use %{find_lang} to build the file list. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review