Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483250 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|fabian@xxxxxxxxxxxxxxxxx |hdegoede@xxxxxxxxxx --- Comment #13 from Hans de Goede <hdegoede@xxxxxxxxxx> 2009-04-03 07:16:03 EDT --- Hi Johan, As discussed by mail already, I'll review your current 4 package submissions, and once they are all approved, I'll sponsor you. I've done a full review of this package and I fully agree with Fabian, please change the %'s in the changelog to %% and add a whiteline between the different release entries, iow change this: * Fri Jan 30 2009 Johan Vromans <jvromans@xxxxxxxxxxx> - 4.2-3 - Fixed URL and Source urls - Added %{?dist} to Release - Fixed missing (optional) argument to %defattr - Changed examples to examples/* to include all examples * Fri Jan 30 2009 Johan Vromans <jvromans@xxxxxxxxxxx> - 4.2-2 - Update description - Add patch to fix Makefiles to avoid double install of manual pages - use smp_mflags - use install -p * Thu Jan 29 2009 Johan Vromans <jvromans@xxxxxxxxxxx> - 4.2-1 - First Fedora version To: * Fri Jan 30 2009 Johan Vromans <jvromans@xxxxxxxxxxx> - 4.2-3 - Fixed URL and Source urls - Added %%{?dist} to Release - Fixed missing (optional) argument to %%defattr - Changed examples to examples/* to include all examples * Fri Jan 30 2009 Johan Vromans <jvromans@xxxxxxxxxxx> - 4.2-2 - Update description - Add patch to fix Makefiles to avoid double install of manual pages - use smp_mflags - use install -p * Thu Jan 29 2009 Johan Vromans <jvromans@xxxxxxxxxxx> - 4.2-1 - First Fedora version Otherwise its fine. Fabian, re-assigning to me since I'm going to sponsor Johan, and thanks for your review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review