Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483286 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |hdegoede@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |hdegoede@xxxxxxxxxx Flag| |fedora-review? --- Comment #6 from Hans de Goede <hdegoede@xxxxxxxxxx> 2009-04-03 07:06:34 EDT --- Hi Johan, As discussed by mail already, I'll review your current 4 package submissions, and once they are all approved, I'll sponsor you. I've done a full review of this package all in all it looks good, except for a few small things (see below). MUST FIX -------- * Drop the patch and (Build)Requires perl(Text::CSV) instead of Text::CSV_XS I know you are upstream, but we do not want to deviate from upstream when not necessary and since you've now also packaged TEXT::CSV, there is no reason for the patch anymore. * Add Changes and README to %doc SHOULD FIX ---------- * Add following to spec: BuildRequires: perl(HTML::Entities) Requires: perl(HTML::Entities) I know this is optional but in Fedora we always try to enable as much features in packaes as possible, even if this drags in a few additional dependencies. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review