Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pulseaudio: Improved Linux sound server https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195221 rdieter@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(drzeus- | |bugzilla@xxxxxxxxx) ------- Additional Comments From rdieter@xxxxxxxxxxxx 2006-08-21 08:06 EST ------- 0. Comment in specfile: # configure --disable-static had no effect; delete manually. FYI, this is most likely due to your using LIBTOOL=/usr/bin/libtool No suggestion here, just an FYI. (: 1. SHOULD/COULD: You could use the %{fedora} macro (defined in Fedora's buildsystem), to conditionalize this bit: # FC5 BuildRequires: libXt-devel, xorg-x11-proto-devel # FC4 or earlier # BuildRequires: xorg-x11-devel into something like: %if "%{?fedora}" > "4" BuildRequires: libXt-devel, xorg-x11-proto-devel %else BuildRequires: xorg-x11-devel %endif But I'll leave the choice of doing this up to you (you're the one that'll have to maintain it afterall). 2. Regarding split-out server/client libs/modules. Will pulseaudio apps link with these (and automatically include them as dependancies)? If yes and/or dependancies are handled automatically for end-users, end of problem. If no, how will users' get these extra dependancies installed on their machines (other than doing so manually)? Address this last 2 issues, and I'll APPROVE this (and sponsor you). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review