[Bug 488124] Review Request: gnubik - 3D interactive graphics puzzle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488124





--- Comment #8 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx>  2009-03-11 22:31:21 EDT ---
Everything is good except there is one little thing that is actually my fault.

The "makeinfo doc/%{name}.texinfo" command builds the %{name}.info file in the
root of the source tree, not in the doc/ directory. Moreover, if the
%{name}.info file in the doc/ directory is missing the Makefile will build it,
provided that texinfo is available.

So instead of using "makeinfo doc/%{name}.texinfo" in build, we just need to do
"rm doc/%{name}.info" in %prep and the Makefile will take care of the rest.

This is the only change that needs to be done and again I'm sorry for the
confusion. I should have been more careful. I'm approving the package now.
Please correct this issue before you commit.

-----------------------------------------
This package (gnubik) is APPROVED by oget
-----------------------------------------


By the way. It took me about 10 minutes to solve the 3x3x3 cube with this game.
It normally takes me about ~90 seconds on a real cube. Any tips? :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]