Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=468631 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review? --- Comment #13 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-03-11 22:01:18 EDT --- Builds fine and rpmlint is silent. Since this package has only static libraries, it's OK that they're in the devel package but you must provide libgarmin-static (and any packages that need to link against the .a need build dependencies on it). Most files don't seem to have a license block; those that do are GPLv2 (only) and the author adds a note at the head of the COPYING file which clarifies v2 only for the rest. The description could use a little cleanup. I would suggest something like: Libgarmin is a library used to parse IMG files from Garmin GPS devices. The COPYING, REAMDE and TODO files are duplicated. You should choose one package to contain them. * source files match upstream (manually compared with checkout). * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. X description could use a bit of grammar work. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. X final provides and requires: libgarmin-0-0.5.20090212svn.fc11.x86_64.rpm libgarmin = 0-0.5.20090212svn.fc11 libgarmin(x86-64) = 0-0.5.20090212svn.fc11 = (none) libgarmin-devel-0-0.5.20090212svn.fc11.x86_64.rpm pkgconfig(libgarmin) = 0.1 libgarmin-devel = 0-0.5.20090212svn.fc11 libgarmin-devel(x86-64) = 0-0.5.20090212svn.fc11 X needs libgarmin-static = /usr/bin/pkg-config libgarmin = 0-0.5.20090212svn.fc11 pkgconfig * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. X duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * headers are in the -devel package. * pkgconfig files are in the -devel package; pkgconfig dependency is present. X static libraries are in the -devel package, but there is no -static provide. * no libtool .la files. The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review