Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gcin - Chinese input method server for Traditional Chinese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-08-18 00:22 EST ------- 1.2.2-2 does indeed build on x86_64 and rpmlint is quiet to boot. Note that I haven't signed on to review this package, but since I have the build logs in front of me I'll check a few things. You don't use the %{?dist} tag. It's not required but it does make maintenance across multiple releases much easier and you should probably use it unless you know that you don't want to. See http://fedoraproject.org/wiki/Packaging/DistTag for more information. You must include the COPYING file in %doc. You should also consider including ChangeLog, and putting README in the main package instead of the -devel subpackage if it includes any end-user documentation. (I am not capable of reading it so I can't tell. The configure script isn't a regular configure script, so I'm not sure it's productive to call it with the %configure macro, which will call configure with many flags that it doesn't seem to understand. It looks like the Makefile ignores CFLAGS, so the compiler is not called with the proper set of flags. I think you will need to patch the makefile, or perhaps the generated config.mak. I added the following hack to the end of %prep: perl -pi -e "s/^(OPTFLAGS.*=)/\1 %{optflags} /" config.mak and it does get the right flags passed to the compiler, but it also causes the build to fail on my 8CPU machine unless I disable parallel make. I have no idea why. I have a suspicion it has something to do with the "-pipe" option. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review