Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483451 --- Comment #4 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-03-07 22:41:15 EDT --- Thanks for the update. (In reply to comment #3) > - rm the 3x links > - creates new relative symbolic links > You put one "../" too much. Also you may want update the script for symlinking to something like: # remove symlinks with absolute paths, and recreate with relative paths cd %{buildroot}/%{_docdir}/HTML/ for lang in *; do ln -sf ../common $lang/%{name}/ done So that if upstream adds other languages you won't need to modify the script. > ===== > In running with debuginfo inside gdb: > $ gdb k3guitune > GNU gdb Fedora (6.8-29.fc10) > Copyright (C) 2008 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. Type "show copying" > and "show warranty" for details. > This GDB was configured as "i386-redhat-linux-gnu"... > (gdb) r > Starting program: /usr/bin/k3guitune > shell-init: error retrieving current directory: getcwd: cannot access parent > directories: No such file or directory > [Thread debugging using libthread_db enabled] > [New Thread 0xb7fd3700 (LWP 10675)] > Detaching after fork from child process 10682. > shell-init: error retrieving current directory: getcwd: cannot access parent > directories: No such file or directory > kbuildsycoca running... > Couldn't initialize Arts: can't connect to aRts soundserver > [New Thread 0xb3d32b90 (LWP 10710)] > ALSA audio initialized succesfully > Audio driver initialized > [Thread 0xb3d32b90 (LWP 10710) exited] > > Program exited normally. > (gdb) q > == > Is the shell-init - cannot access parent directories an issue ? > > ===== > In running from the command line: > $ k3guitune > Couldn't initialize Arts: can't connect to aRts soundserver > ALSA audio initialized succesfully > Audio driver initialized > == > It seems to take a few seconds to start up (for such a small program), even > after it has just been running. Would it be worth trying to disable > detection/connection to arts ? > The program doesn't work for me with arts at all. No crashes though. It just behaves like it receives no sound. So I can't say anything for this. If you want to disable arts support, be my guest. > ===== > I noticed that configure has a look for bio2jack's presence. Would it be OK, to > have a single version that is both alsa (which shows up, and record level > control can be controlled in the pulseaudio volume control) and jack enabled, > or would it be better to package it built for jack separately ? > > I haven't looked in detail at what would be involved, it works for me as is, > and would make it easier for Fedora music enthusiasts (who don't know/want to > mess with the intricacies of jack) to use the tuner. If you enable jack support, it won't mess up with the alsa support. You just add add BR: bio2jack-devel and another checkbox for jack fill appear on the audio settings dialog. It is not necessary to have jack support though. It would be just a bonus. There are a few more things that I caught in the second pass. * The desktop scriptlets need to be updated according to new guidelines https://fedoraproject.org/wiki/PackagingDrafts/Icon_Cache https://www.redhat.com/archives/fedora-devel-list/2009-February/msg01604.html https://www.redhat.com/archives/fedora-devel-list/2009-February/msg01273.html * We need to preserve timestamps for the files: ChangeLog AUTHORS You can use touch -r $nonutffile $nonutffile.conv for this purpose. * We don't need to package the file INSTALL I'll do the full review very soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review