Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486757 Peter Rockai <prockai@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |prockai@xxxxxxxxxx --- Comment #4 from Peter Rockai <prockai@xxxxxxxxxx> 2009-03-03 04:41:16 EDT --- Hi, I suppose it is generally fine, however please note I don't have a fedora installation handy where I could test the packages. You might also want to consider checking that the outcome of the tests you put in %check is correct (you can use --report and some simple grepping for that). Actually, DiVinE 2.0 will come with a bunch of unit and functional tests bundled, so running those will be probably preferable. First release on the 2.0 branch is planned in a course of few weeks. However, looking at http://fedoraproject.org/wiki/Releases/11/Schedule I guess we will miss Fedora 11 with that release, so adding a few checks to the spectime in the meantime would be nice. Cf. https://anna.fi.muni.cz/divine/trac/browser/test/reachability.sh https://anna.fi.muni.cz/divine/trac/browser/test/owcty.sh Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review