Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485159 --- Comment #4 from Christian Krause <chkr@xxxxxxxxxxx> 2009-02-27 15:21:38 EDT --- Thank you very much for the review! (In reply to comment #3) > The package is internationalized, with .mo files for libanki and libankiqt. > Unfortunately, they're in a location that %find_lang > (https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files) > doesn't know how to find them in > (%{python_sitelib}/ankiqt/locale/*/LC_MESSAGES). Since you can't use > %find_lang, you're going to have to tag those files manually, like this: I've fixed the problem as suggested. > It is also possible to script a version of find_lang that can find these files > and tag them properly in a file list to use in %files, but that might be more > complicated than doing what I've proposed. Yeah, this makes the spec file a little bit more complicated. I'll try to get this problem fixed upstream, but for now I think it's ok! ;-) > rpmlint caught this problem, you should run rpmlint on your packages to look > for issues like this. :) rpmlint SPECS/anki.spec RPMS/noarch/anki-0.9.9.6-3.fc10.noarch.rpm SRPMS/anki-0.9.9.6-3.fc10.src.rpm anki.src: W: strange-permission generate-anki-tarball.sh 0755 2 packages and 1 specfiles checked; 0 errors, 1 warnings. The remaining warning is about the mode of the script to generate the distributable tarball. Since the file is an executable shell script it may be ok... > Show me a new package that has this issue fixed and I'll finish out this > review. Great! The new package is uploaded: Spec URL: http://www-user.tu-chemnitz.de/~tiwi/anki.spec SRPM URL: http://www-user.tu-chemnitz.de/~tiwi/anki-0.9.9.6-3.fc10.src.rpm and builds fine in F10 and F11: https://koji.fedoraproject.org/koji/taskinfo?taskID=1206089 https://koji.fedoraproject.org/koji/taskinfo?taskID=1206084 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review