Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485159 --- Comment #3 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2009-02-27 10:13:48 EDT --- Christian, at first glance, this package looks great. I only noticed one thing when I did the review: The package is internationalized, with .mo files for libanki and libankiqt. Unfortunately, they're in a location that %find_lang (https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files) doesn't know how to find them in (%{python_sitelib}/ankiqt/locale/*/LC_MESSAGES). Since you can't use %find_lang, you're going to have to tag those files manually, like this: %lang(cs) %{python_sitelib}/ankiqt/locale/cs_*/ (rpm tags on the first half of the locale country code only) Unfortunately, this will make your %files more complicated, as you cannot simply claim the toplevel directory or these files will be listed twice. Start with something like this: %files %defattr(-,root,root,-) %doc COPYING ChangeLog CREDITS README* %dir %{python_sitelib}/ankiqt/ %{python_sitelib}/ankiqt/*.py* %{python_sitelib}/ankiqt/forms/ %{python_sitelib}/ankiqt/ui/ %dir %{python_sitelib}/ankiqt/locale/ %lang(cs) %{python_sitelib}/ankiqt/locale/cs_*/ %lang(de) %{python_sitelib}/ankiqt/locale/de_*/ ... It is also possible to script a version of find_lang that can find these files and tag them properly in a file list to use in %files, but that might be more complicated than doing what I've proposed. rpmlint caught this problem, you should run rpmlint on your packages to look for issues like this. :) Show me a new package that has this issue fixed and I'll finish out this review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review