Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-SDL - SDL bindings for the Perl language https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202437 ------- Additional Comments From kevin@xxxxxxxxx 2006-08-16 01:12 EST ------- ugh. I thought I checked all the files, but I missed that patch, you are right. Sorry for the trouble... Since this is pretty much a totally new package, I will go ahead and run thru my review checklist on it again. ;) OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (LGPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 6ce26e1b710ce52def4ec22637cd5176 SDL_Perl-2.1.3.tar.gz 6ce26e1b710ce52def4ec22637cd5176 SDL_Perl-2.1.3.tar.gz.1 OK - Package compiles and builds on at least one arch. n/a - Package needs ExcludeArch OK - BuildRequires correct n/a - Spec handles locales/find_lang n/a - Spec has needed ldconfig in post and postun n/a - Package is relocatable and has a reason to be. OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. n/a - -doc subpackage needed/used. OK - Packages %doc files don't affect runtime. n/a - Headers/static libs in -devel subpackage. n/a - .pc files in -devel subpackage. n/a - .so files in -devel subpackage. n/a - -devel package Requires: %{name} = %{version}-%{release} n/a - .la files are removed. n/a - Package is a GUI app and has a .desktop file OK - Package doesn't own any directories other packages own. See below - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. OK - Should build in mock. Issues: 1. rpmlint says: W: perl-SDL strange-permission filter-depends.sh 0755 I think that can be ignored. It should be 755 I would think. 2. I see the package is providing: perl(Walker) and perl(main) Is that correct or should those be filtered out as well? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review