Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485954 --- Comment #5 from Dodji Seketeli <dodji@xxxxxxxxxx> 2009-02-19 10:13:40 EDT --- I have updated the spec/srpm following your comments, at: http://people.redhat.com/dseketel/rpms/marlin/marlin-3.spec http://people.redhat.com/dseketel/rpms/marlin/marlin-0.13-3.fc10.src.rpm The build results for F-10 and F-11 are at: http://koji.fedoraproject.org/koji/taskinfo?taskID=1139769 http://koji.fedoraproject.org/koji/taskinfo?taskID=1139841 > --- Comment #4 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-02-19 03:45:30 EDT --- [...] > > - '--vendor fedora' is obsolete Right. Removed. > https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files > - Isn't 'BuildRequires: gettext' (for translation) I believe this is in the Requires of intltool that is BuildRequire'ed by Marlin already. > and 'Requires: hicolor-icon-theme' (for icons) missing? I believe this is in the Requires of gtk2 that is BuildRequired'd by Marlin already. > - Unversioned shared libraries should go into a -devel subpackage Ah, in theory yes. But I did talk with upstream about this and he doesn't want to have a devel package yet, even though the architecture of marlin is done so that external apps can benefit from it's internal libraries. The reason is that the internal libraries are still a moving target so he can't guarantee any API/ABI compatibility yet. When he can do that, we can start shipping a -devel package I think. Does this make any sense ? > - Take a look at > https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database > about 'Requires(post)/(postun): desktop-file-utils' > Okay. Thanks. I removed the 'Requires(post)/(postun): desktop-file-utils'. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review