Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485954 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #4 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-02-19 03:45:30 EDT --- Some other quick comments on your spec file - '--vendor fedora' is obsolete https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files - Isn't 'BuildRequires: gettext' (for translation) and 'Requires: hicolor-icon-theme' (for icons) missing? - Unversioned shared libraries should go into a -devel subpackage https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages - Take a look at https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database about 'Requires(post)/(postun): desktop-file-utils' -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review