Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473583 --- Comment #12 from steve <steve@xxxxxxxxxxxx> 2009-02-18 15:22:07 EDT --- Thanks for the review spot. (In reply to comment #10) > Two issues here: > > 1. please use %{_datadir} instead of /usr/share. Done. > 2. These files shouldn't be in the package. > /usr/share/wordnet-3.0/include/tk > /usr/share/wordnet-3.0/include/tk/tk.h > /usr/share/wordnet-3.0/include/tk/tkDecls.h ... ... > I'll attach a patch to remove it from the Fedora package. You'd need to apply > this patch and also delete the include/tk dir in %prep. Applied you patch, and made the change in %prep. > > Show me a fixed package and I'll finish this review. The new package & spec is at: http://www.lonetwin.net/wordnet.spec http://lonetwin.net/wordnet-3.0-4.fc10.src.rpm - steve -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review