Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473583 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx Flag| |fedora-review? --- Comment #10 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2009-02-18 14:07:59 EDT --- Two issues here: 1. please use %{_datadir} instead of /usr/share. 2. These files shouldn't be in the package. /usr/share/wordnet-3.0/include/tk /usr/share/wordnet-3.0/include/tk/tk.h /usr/share/wordnet-3.0/include/tk/tkDecls.h In fact, upstream really shouldn't be shipping these files as part of wordnet, they should rely on the system tk-devel (they're using the system libtk, but providing mismatched tk headers?). I'll attach a patch to remove it from the Fedora package. You'd need to apply this patch and also delete the include/tk dir in %prep. Show me a fixed package and I'll finish this review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review