Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482757 Pierre-YvesChibon <pingou@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pingou@xxxxxxxxxxxx --- Comment #5 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> 2009-02-18 11:13:43 EDT --- I cannot do the review since I'm not a sponsor but I looked at the spec file Several minor points: * You can use the macro %{name} instead of Fox in a number of places in the spec ie: > Source0: http://dfn.dl.sourceforge.net/sourceforge/objcryst/Fox-1.8.0.3-R1088.tar.bz2 becomes > Source0: http://dfn.dl.sourceforge.net/sourceforge/objcryst/%{name}-%{version}-R1088.tar.bz2 that can save you some problem for later update * Please add an extra \n between two change in the changelog (some tool used within Fedora need these white line between the change): ie: > * Sat Feb 14 2009 Pascal < pascal22p@xxxxxxxxxx > - 1.8.0.3-1 > - Fixed reading, writing files and display of labels in the linux unicode version of Fox > * Fri Feb 06 2009 Pascal < pascal22p@xxxxxxxxxx > - 1.8.0-2 becomes > * Sat Feb 14 2009 Pascal < pascal22p@xxxxxxxxxx > - 1.8.0.3-1 > - Fixed reading, writing files and display of labels in the linux unicode version of Fox It might be nice also to give to the reviewer an input file and an output file so that the software could actually be tested :) You might also be interested to join the SciTech SIG: https://fedoraproject.org/wiki/Category:SciTech_SIG > * Fri Feb 06 2009 Pascal < pascal22p@xxxxxxxxxx > - 1.8.0-2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review