Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476404 --- Comment #22 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-02-17 11:37:33 EDT --- For 2.73-3: * License - Now the license tag for this package should be "zlib and MIT and BSD". * All codes under Demos/ Extras/ Glut/ are now removed. * Also all files under mk/ are not used. * Source0 - By the way the tarball included in your srpm differs from what I could download from the URL written in the spec file. If you created the tarball by yourself, please write some comments in the spec file how you created the tarball. https://fedoraproject.org/wiki/Packaging/SourceURL#When_Upstream_uses_Prohibited_Code * Redundant BuildRequires - "BuildRequires: gcc-c++" is redundant on Fedora. ref: https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 * Compiler flags - On Fedora the default optimation level is -O2 (you can check this by $ rpm --eval %optflags). However currently this software uses -O3. ------------------------------------------------------------------------ 96 [ 0%] [ 2%] [ 2%] [ 3%] Building CXX object src/LinearMath/CMakeFiles/LinearMath.dir/btAlignedAllocator.o 97 Building CXX object src/LinearMath/CMakeFiles/LinearMath.dir/btQuickprof.o 98 cd /builddir/build/BUILD/bullet-2.73/src/LinearMath && /usr/bin/c++ -DLinearMath_EXPORTS -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -O3 -DNDEBUG -fPIC -I/usr/local/include -I/builddir/build/BUILD/bullet-2.73/src -I/builddir/build/BUILD/bullet-2.73/src/LinearMath/} -o CMakeFiles/LinearMath.dir/btAlignedAllocator.o -c /builddir/build/BUILD/bullet-2.73/src/LinearMath/btAlignedAllocator.cpp ------------------------------------------------------------------------ If you don't have some reason you prefer to use -O3 optimization level, please remove this. * ldconfig symlinks ------------------------------------------------------------------------ ]# ls -al /usr/lib/libBulletCollision* lrwxrwxrwx 1 root root 26 2009-02-18 00:56 /usr/lib/libBulletCollision.so -> libBulletCollision.so.2.73 -rwxr-xr-x 1 root root 706252 2009-02-17 00:34 /usr/lib/libBulletCollision.so.2.73 ------------------------------------------------------------------------ - Usually in this case the (soft) symlink named "libBulletCollision.so.2" which points to libBulletCollision.so.2.73 should also be provided and the symlink (libBulletCollision.so.2) should be included in bullet package (see libjpeg and libjpeg-devel rpms for example) * Directory ownership issue - For example: ------------------------------------------------------------------------ $ LANG=C rpm -qf /usr/include/LinearMath/btList.h bullet-devel-2.73-3.fc11.i386 $ LANG=C rpm -qf /usr/include/LinearMath/ file /usr/include/LinearMath is not owned by any package ------------------------------------------------------------------------ Here -devel subpackage installs btList.h under %_includedir/Linearmath, however the directory %_includedir/Linearmath itself is not owned by any packages, which must be owned by bullet-devel. ref: https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership https://fedoraproject.org/wiki/Packaging/UnownedDirectories * Duplicate documents - There is no need to include the same document files into both main package and -devel subpackage. * Misc rpmlint issue ------------------------------------------------------------------------ bullet.src:77: W: macro-in-%changelog post bullet.src:78: W: macro-in-%changelog description bullet.src:79: W: macro-in-%changelog summary bullet.src:80: W: macro-in-%changelog group bullet.src:82: W: macro-in-%changelog description bullet.i386: W: file-not-utf8 /usr/share/doc/bullet-2.73/ChangeLog bullet-debuginfo.i386: W: spurious-executable-perm /usr/src/debug/bullet-2.73/src/LinearMath/btPoolAllocator.h bullet-debuginfo.i386: E: wrong-script-end-of-line-encoding /usr/src/debug/bullet-2.73/src/LinearMath/btPoolAllocator.h bullet-debuginfo.i386: W: spurious-executable-perm /usr/src/debug/bullet-2.73/src/BulletDynamics/ConstraintSolver/btSliderConstraint.cpp bullet-debuginfo.i386: E: wrong-script-end-of-line-encoding /usr/src/debug/bullet-2.73/src/BulletDynamics/ConstraintSolver/btSliderConstraint.cpp bullet-debuginfo.i386: W: spurious-executable-perm /usr/src/debug/bullet-2.73/src/BulletDynamics/ConstraintSolver/btSliderConstraint.h bullet-debuginfo.i386: E: wrong-script-end-of-line-encoding /usr/src/debug/bullet-2.73/src/BulletDynamics/ConstraintSolver/btSliderConstraint.h bullet-devel.i386: W: file-not-utf8 /usr/share/doc/bullet-devel-2.73/ChangeLog ----------------------------------------------------------------------- - In %changelog, please use %% instead of single % to prevent macros from being expanded. - Please change the encoding of ChangeLog file to UTF-8 (use iconv) - For spurious-executable-perm and wrong-script-end-of-line-encoding rpmlint for debuginfo rpm, this usually means that the source code file has executable permission. Change the permission of those files to 0644 (at %prep) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review