Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484644 --- Comment #11 from leigh scott <leigh123linux@xxxxxxxxxxxxxx> 2009-02-15 10:57:22 EDT --- (In reply to comment #10) > So here are the new files. > SPEC: http://www.linuxed.net/~madko/fedora/screenlets.spec > SRPM: http://www.linuxed.net/~madko/fedora/screenlets-0.1.2-2.fc10.src.rpm > RPM: http://www.linuxed.net/~madko/fedora/screenlets-0.1.2-2.fc10.noarch.rpm > > btw, I use desktop-file-validate instead of desktop-file-install because the > desktop file is already installed in the good place. Is it ok? I believe it is acceptable to use desktop-file-validate. > > I also add some french translation in the desktop file, do I have the right to > do that? I not sure. The summary is better, but still needs to be shorter. [leigh@localhost Download]$ rpmlint -vi '/home/leigh/Download/screenlets-0.1.2-2.fc10.noarch.rpm' screenlets.noarch: I: checking screenlets.noarch: E: summary-too-long Screenlets are fully themeable mini-apps that improve the usability and eye-candy of the modern composited Linux-desktop The "Summary:" must not exceed 79 characters. 1 packages and 0 specfiles checked; 1 errors, 0 warnings. [leigh@localhost Download]$ rpmlint -vi '/home/leigh/Download/screenlets-0.1.2-2.fc10.src.rpm' screenlets.src: I: checking screenlets.src: E: summary-too-long Screenlets are fully themeable mini-apps that improve the usability and eye-candy of the modern composited Linux-desktop The "Summary:" must not exceed 79 characters. 1 packages and 0 specfiles checked; 1 errors, 0 warnings. [leigh@localhost Download]$ This bit is wrong Source0: %{name}-%{version}.tar.bz2 You must use a full URL to the package in the SourceX: line. i.e Source0: http://code.launchpad.net/screenlets/trunk/0.1.2/+download/%{name}-%{version}.tar.bz2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review