Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485496 --- Comment #2 from Dodji Seketeli <dodji@xxxxxxxxxx> 2009-02-15 10:23:02 EDT --- {?dist} macro: > https://fedoraproject.org/wiki/Packaging/DistTag Done. > - Source0 must be given with full URL: > https://fedoraproject.org/wiki/Packaging/SourceURL Done. > > - gegl-devel Requires babl-devel, so "BuildRequires: babl-devel" > is redundant. I Removed babl-devel. > - Usually the dependencies between binary rpms rebuilt from > a srpm must be EVR (not just version) specific. > https://fedoraproject.org/wiki/Packaging/Guidelines#Requiring_Base_Package Done. > - This srpm won't build on dist-f11: > http://koji.fedoraproject.org/koji/taskinfo?taskID=1126647 > Ah. It builds on f10 that's why I didn't notice that. I will now use mock. So I did a patch to fix this issue. The patch has been submitted upstream. While at it, I produced another patchlet to kill some warnings. That patch has been submitted upstream as well. > - We recommend %defattr(-,root,root,-) Done. > - Please consider to add the following files > ------------------------------------------------------------ > AUTHORS > COPYING > COPYING.LESSER > ------------------------------------------------------------ > to main package and > ------------------------------------------------------------ > ChangeLog > ------------------------------------------------------------ > to -devel package. > Done. Thanks for the quick review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review