Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462521 --- Comment #6 from John Guthrie <guthrie@xxxxxxxxxxxxxxxxxx> 2009-02-08 23:37:09 EDT --- (In reply to comment #5) > (In reply to comment #2) > > [-] Other source files are included: > > Please check the status and the necessity of using the files in > > src/com/sun and de/calcom as they appear to come from other projects. > > The short story is that from what I can tell, these files actually are imported > into the files for this project. I will talk more about this later when it is > not 2AM and I am needing sleep. ;-) This could end up being a bit of a mess. Just looking at the file com/sun/demo/ExampleFileFilter.java, the class defined by this file gets imported into three different files under com.lightdev. Moreover, these files use methods that are defined in ExampleFileFilter.java. It would be difficult to extricate this class from the com.lightdev tree without making semi-substantial changes to the code. On further inspection, one also sees that the ExampleFileFilter class extends the FileFilter class. The documentation for that class can be found here: http://java.sun.com/j2se/1.4.2/docs/api/javax/swing/filechooser/FileFilter.html According to that page, the FileFilter class is in fact an abstract class, so it is expected that a subclass will be written in order to implement this class. It appears that this particular subclass, ExampleFileFilter, was written to, well, be an example implementation. However, I am guessing that the example code did everything that the simplyhtml upstream wanted, and so they just used it directly, rather than writing their own implementation. Fortunately, ExampleFileFilter.java has a 3-clause BSD license with no advertising clause. Similar comments apply to ElementTreePanel.java. All of the de.calcom code has been placed under GPL just like the rest of the com.lightdev code. IT turns out that the lightdev.com and calcom.de domains are owned by the same person, one Ulrich Hilger. Moreover, looking at the calcom.de web site, it would appear that calcom.de was a previous name for lightdev.com. Based on this, it would seem safe to assume that the de.calcom code is part of the "same" project as the com.lightdev code. Is there anything that we would need to worry about with the com.sun.demo code having a BSD license vs. the rest of the code having a GPL license? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review