Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462521 --- Comment #5 from John Guthrie <guthrie@xxxxxxxxxxxxxxxxxx> 2009-02-08 02:34:43 EDT --- (In reply to comment #2) I have posted a new spec file and SRPM. Here are the URLs: Spec: http://www.guthrie.info/RPMS/f10/simplyhtml.spec SRPM: http://www.guthrie.info/RPMS/f10/simplyhtml-0.12.5-2.fc10.src.rpm > [-] source files match upstream: > I followed the instructions in the spec file and ended up with > something with a different md5sum than the file in the SRPM. The > readme.txt and gpl.txt files do match though > > You could just use the upstream .zip file directly, though. Just change > your %setup line to > %setup -q -c %{name}-%{version} > and it'll create the directory when it needs to. For the 0.12.5 version, the upstream is now offering the source in .tar.gz format. I am now using that unmodified. > [-] latest version is being packaged. > It looks like upstream has released 0.12.5 This is fixed. 0.12.5 is now packaged. > [-] package builds in mock. > error: %patch without corresponding "Patch:" tag > You should have "%patch0", not "%patch", on line 62 > For the remainder of this review I made this change This is fixed. > [-] rpmlint is silent. > One warning to deal with: > simplyhtml.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line > 20) > The specfile mixes use of spaces and tabs for indentation, which is a > cosmetic > annoyance. Use either spaces or tabs for indentation, not both. This is fixed. > [-] Package doesn't run > I recommend creating a small shell script to run the program with the > correct CLASSPATH -- if you just try to run the jar file, it doesn't > find the gnu-regexp classes. > > Something like this: > > #!/bin/sh > > exec java -cp `build-classpath gnu-regexp javahelp2 simplyhtml` \ > com.lightdev.app.shtm.App I did this almost verbatim except that I added simplyhtml-help to the build-classpath command. > [-] Other source files are included: > Please check the status and the necessity of using the files in > src/com/sun and de/calcom as they appear to come from other projects. The short story is that from what I can tell, these files actually are imported into the files for this project. I will talk more about this later when it is not 2AM and I am needing sleep. ;-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review