Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-manual-en - English language PHP manual Alias: php-manual-en https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196281 ------- Additional Comments From chris.stone@xxxxxxxxx 2006-08-10 17:33 EST ------- -rpmlint output clean -package named according to Package Naming Guidelines -spec file name matches package %{name} -package licensed with open-source compatible license O I could not find the license file in the package or on the web site. Please let me know where I can find the upstream license -license file not included in %doc -spec file written in American English -spec file legible -source matches upstream a8ef43e9ff1da2ce18df90e67fc5758f php_manual_en.tar.gz -package successfully compiles and builds on FC-5 x86_64 -package does not need any BuildRequires -spec file does not contain any locales -package does not contain any shared libraries -package is not relocatable -package owns all directories it creates -package does not contain any duplicate files in %files -file permissions set properly -package contains proper %clean section -macro usage is consistent -package contains permissible content -use of -doc subpackage does not make sense in this context since package is already a doc package -package does not include %doc -package does not include header files or static libraries -package does not use pkgconfig -package does not contain any .so files -package does not build a -devel subpackage -package does not contain any .la files -package is not a GUI needing a .desktop file -package does not own files or directories owned by other packages ==== MUST ==== - Explain where documentation is licensed ==== SHOULD ==== - include a license file and place it in %doc -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review