Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196281 Summary: Review Request: php-manual-en - English language PHP manual Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@xxxxxxxxxxxxx ReportedBy: rpm@xxxxxxxxxx QAContact: fedora-package-review@xxxxxxxxxx Spec URL: http://www.timj.co.uk/linux/specs/php-manual-en.spec SRPM URL: http://www.timj.co.uk/linux/srpms/php-manual-en-20060527-1.src.rpm Description: A documentation-only package containing the English language version of the PHP manual, split into a file per chapter. See thread starting: https://www.redhat.com/archives/fedora-extras-list/2006-May/msg00237.html for a discussion of a number of issues relating to this package. A few quick points: - rpmlint says: W: php-manual-en invalid-license Open Publication License v1.0 I think this is OK, since the above string is the correct and most accurate description of the package license - Arguably the package should be php-manual-en-us, since in theory there might be an en_GB manual at some point, but I wonder whether this is going too far with the whole abstraction - the Source URL is not really right for two reasons: a) it has to have a silly /mirror/rubbish/junk on the end b) it doesn't include the version in it but this is an upstream problem. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review