Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479835 --- Comment #4 from Alex Hudson (Fedora Address) <fedora@xxxxxxxxxxxxxx> 2009-01-26 09:56:02 EDT --- Kevin, Thanks for the detailed comments, much appreciated. Updated SRPM: http://www.alexhudson.com/fedora/log4c/log4c-1.2.1-2.fc10.src.rpm SPEC: http://www.alexhudson.com/fedora/log4c/log4c.spec 1: The %check was there to remind me to tie in the built-in tests; however, they fail to run cleanly at the moment - indeed, with the current compiler flags, one crashes very nicely. I've removed this entirely for now; I suspect the tests needs to be reworked upstream before being useful here. 2, 3, 4: Thanks! 5: Well, it was optional, but the config parsing seems much more robust using Expat instead of the built-in grammar, so I've changed it to use that 6: Yes, indeed - I'll follow this up with the log4c guys 7: I'm going to disagree with you here ;) The .m4 file is there as a convenience for automake-using developers; you don't need to use automake to compile against log4c. E.g, I have a project here using CMake to build against log4c - it doesn't need that macro at all. Thanks again! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review