Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476973 --- Comment #2 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2009-01-25 14:42:39 EDT --- Spec URL: http://akurtakov.fedorapeople.org/eclipse-rpmstubby.spec SRPM URL: http://akurtakov.fedorapeople.org/eclipse-rpmstubby-0.1.0-1.fc10.src.rpm (In reply to comment #1) > I made the review. There are a few minor things to go over: > > * Two Changelogs need packaged: > ./org.eclipse.linuxtools.rpmstubby-feature/ChangeLog > ./org.eclipse.linuxtools.rpmstubby/ChangeLog > Fixed > * I think URL needs to be: > http://www.eclipse.org/linuxtools/projectPages/rpmstubby/ > Fixed > ? Could you provide a download location at the project homepage so we don't > need to use this fetch script? Not yet because the project needs to be reviewed from eclipse.org before making official releases. > > * Macros should be used consistently. You use %{buildroot} and $RPM_BUILD_ROOT > mixed. This needs corrected. You should also use %{__install} for consistency. > Fixed. > * Summary looks awkward to me, maybe it should be shortened to: > Rpm specfile generator for Eclipse > Current summary describes better what the plugin is doing. > > These are all easy to do. I'm approving the package now. > > > ---------------------------------------------------- > This package (eclipse-rpmstubby) is APPROVED by oget > ---------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review