Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480886 --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-01-25 14:46:43 EDT --- Created an attachment (id=329952) --> (https://bugzilla.redhat.com/attachment.cgi?id=329952) some trial patch For 0.3.1-1: * About Patch2: - Well, google shows that awe_voice.h was removed from kernel headers at 2.6.21 or so (i.e. around Fedora 7) I don't think it is preferrable to re-introduce macros which was defined in the header file which is no longer supported. I guess kernel supports AWE32 in other way or kernel does not support AWE32 completely any more. Are macros related to awe_voice.h really needed even now? (removing all awe32 related parts like attached does not help ? I just tried to remove all awe_voice.h related parts and did not any functionality check as I don't know how to use this software...) * Timestamps - Please consider to use ------------------------------------------------------- make install DESTDIR=%{buildroot} INSTALL="install -p" ------------------------------------------------------- to keep timestamps on installed files. * Directory structure about document files - For HTML files in devel package, I suggest that a subdirectory should be created under %_defaultdocdir/%name-devel-%version (named as "HTML", for example) and all HTML files should be moved into the directory. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review