Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480591 --- Comment #3 from Sarantis Paskalis <paskalis@xxxxxxxxx> 2009-01-20 08:31:01 EDT --- (In reply to comment #2) > 1. needs _texmf_main defined like cm-lgc Fixed. > 2. rpmlint complains of mixed-use-of-spaces-and-tabs Fixed (probably, local rpmlint does not complain, I could not see where tab was) > 3. kerkis calligraphic and the small caps variants clearly needs their own > subpackage. Please make sure you only group in the same font subpackage fonts > of the same family (differing only in weight, width or slant). I didn't check > the others OK with the Calligraphic family. The SmallCaps files however define the font family to be "Kerkis", and not "Kerkis-SmallCaps" or something like that. I put it therefore in the -serif subpackage. The other font files that differentiate themselves are the SemiBold variants, that define a family of "Kerkis-SemiBold". This however is just another weight (like Bold) as described by the font's authors (http://www.tug.org/TUGboat/Articles/tb23-3-4/tb75tsol.pdf), so I placed it in the -serif-fonts subpackage > 4. the main package does not need to > Requires: fontpackages-filesystem Fixed. > 5. It's probably a good idea to add fontconfig substitution rules for the URW > fonts kerkis is derived of, assuming the Kerkis creators didn't change the > design and metrics too much (cf the substitution template in > filepackages-devel) Added some substitution rules for the font family names as displayed in Gnome Character Map. > 6. please try to get you fontconfig files merged in upstream kerkis once you're > happy with them It's kind of dead upstream, and considering that the primary force to create the font was the usage in LaTeX, I don't think I will be very successful. I will try though. > 7. please add your new fonts subpackages to comps > http://fedoraproject.org/wiki/Comps_fonts_rules Will do as soon as there are rawhide rpms. > 8. you obsoletes should be > Obsoletes: tetex-font-kerkis < 2.0-17 > to provide an upgrade path to the F10 kerkis package, so this version does not > pass rename review Fixed. New spec and srpm in the same location http://gallagher.di.uoa.gr/any/rpms/ctan-kerkis-fonts/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review