Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480552 --- Comment #3 from Ruben Kerkhof <ruben@xxxxxxxxxxxxxxxx> 2009-01-19 07:40:02 EDT --- Hi Kevin, thanks for the review. > 1. Seems like all the files that refer to the license say "or later", so > shouldn't this be 'GPLv3+' ? Fixed. > 2. You seem to have a typo in your Source0 line. A 'i' that shouldn't be there. Ah, fat fingers. Fixed as well. > 3. You should probibly require 'httpd' instead of 'webserver' as you are > putting files in httpd specific locations. Hmm, interesting issue. On the one hand, poweradmin works fine with lighttpd under fastcgi for example, on the other hand, most people will run this under apache. Adding the httpd conf file makes it run almost out of the box for the most users. But if you want to run poweradmin under another http server, it would still drag in httpd as a dependency. phpMyAdmin does exactly the same btw. What do you think? > 4. The URL seems wrong... www.poweradmin.org instead of www.poweradmin.com ? Oops, fixed as well. New spec: http://ruben.fedorapeople.org/poweradmin.spec New srpm: http://ruben.fedorapeople.org/poweradmin-2.1.2-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review