Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480552 --- Comment #2 from Kevin Fenzi <kevin@xxxxxxxxx> 2009-01-18 18:33:35 EDT --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv3+) See below - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: cf83b89c6931160684de52a0b3ea3678 poweradmin-2.1.2.tgz cf83b89c6931160684de52a0b3ea3678 poweradmin-2.1.2.tgz.orig OK - BuildRequires correct - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. Seems like all the files that refer to the license say "or later", so shouldn't this be 'GPLv3+' ? 2. You seem to have a typo in your Source0 line. A 'i' that shouldn't be there. 3. You should probibly require 'httpd' instead of 'webserver' as you are putting files in httpd specific locations. 4. The URL seems wrong... www.poweradmin.org instead of www.poweradmin.com ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review