Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479832 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #2 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-01-18 11:12:00 EDT --- Well, some random comments. ! First of all, please check your srpm / binary rpms by rpmlint (in rpmlint rpm) to detect some generic packaging errors. - %define _prefix is not needed. https://fedoraproject.org/wiki/Packaging/RPMMacros - Also, %_prefix/share/man should be %{_mandir} , for example - Please consider to use %{?dist} macro in Release number https://fedoraproject.org/wiki/Packaging/DistTag - "Games" is not valid Group on Fedora. See the explanation by $ rpmlint -I non-standard-group - "GPL 3" license tag is not a valid tag for Fedora: http://fedoraproject.org/wiki/Licensing - Please consider to %{version} macro in Source0: https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D - BuildRoot you are using is not valid on Fedora: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag - Would you explain what the periods at the head of sentences are for? - Please don't use debian's way of naming like "libmmpong0.9" and "%package libs" for example if you want to split libraries and create a seperate rpm. and -devel package should simply be "%package devel". ! note that "%package foo" is the same as "%package -n %{name}-foo". You are using many "%package -n", but almost all of these can (and should) be replaced by "%pacakge foo" (same for %description, %files) - Please write the dependencies between binary rpms created by this srpm. For example -devel subpackage should have "Requires: %{name}-libs = %{version}-%{release}". - By the way would you explain why you have to write "mmpong is an ......" sentence on %description of each subpackages? - %setup should be quiet (use -q option) - Patch0 does not correspond with %patch (rpm 4.6 refuses this. you should use %patch0 if you use Patch0) - By the way your patch cannot not be applied with --fuzz=0 (this is the default on rpm 4.6) - Please check if %cmake macros can be used for this package: https://fedoraproject.org/wiki/Packaging/cmake Also as written in cmake wiki: - support parallel make when possible. Otherwise write in your spec file as comments that this package does not support parallel make : https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make - Perhaps you have to add "VERBOSE=1" option to "make" to make build.log verbose. - %buildroot must once be cleaned at the beginning of %install https://fedoraproject.org/wiki/Packaging/ReviewGuidelines - Please avoid to use %makeinstall unless impossible: https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used - What is %run_ldconfig macro? Also your srpm does not seem to create %{name} package itself. Would you explain why? - %{name}-libs package needs /sbin/ldconfig at %post{,un} (by the way if only /sbin/ldconfig should be executed at %post, use "%post libs -p /sbin/ldconfig", for example) - %defattr is missing on all packages (see ReviewGuidelines wiki) - Please don't ship static archives (libfoo.a) unless needed. If not avoidable, please package it seperately: https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries - By the way would you explain why -devel subpackge contains no header files? (is this -devel subpackage useful?) - Packages containing pkgconfig .pc file must have "Requires: pkgconfig" (written in ReviewGuidelines wiki) - Using %_prefix/games, %_datadir/games is not allowed on Fedora: https://fedoraproject.org/wiki/SIGs/Games/Packaging - Installed desktop file must be handled by desktop-file-{install,validate} https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage - %{_prefix}/share/icons directory _itself_ should not be owned by -gl subpackage: https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership - Please write %changelog https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review