Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libGLw https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188974 ------- Additional Comments From rdieter@xxxxxxxxxxxx 2006-08-07 14:11 EST ------- Looks pretty good so far... offhand, 1. IMO, package should follow upstream name and version, ie, Name: mesa-libGLw Version: 6.5 that is, unless there is (strong, but so far unclear to me?) reasoning to do otherwise. If renamed, then you no longer need the Obsoletes: mesa-libGLw 2. These Obsoletes seem overkill to me: Obsoletes: Mesa Obsoletes: XFree86-libs Obsoletes: xorg-x11-libs These are (should be!) already Obsoleted elsewhere. IMO, no need to include them here. 3. -devel should Requires: libGL-devel since its headers include references to GL/gl.h GL/glx.h 4. (minor/cosmetic) in -devel, change Requires: libGLw = %{version}-%{release} to Requires: %{name} = %{version}-%{release} to save hassle if/when pkg is ever renamed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review