Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478581 Robert Scheck <redhat@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|redhat-bugzilla@xxxxxxxxxxx | |e | Flag| |fedora-review+ --- Comment #2 from Robert Scheck <redhat@xxxxxxxxxxxx> 2009-01-01 13:49:10 EDT --- Lubomir, can you please add the license to %doc of the base package? I know, it is in the header file of -devel as well, but that's not perfect IMHO. So just the license for %doc, not the whole header file. Maybe the license just from the header file as Source2 simply. Package seems sane to me, source matches, debuginfo is okay, description and overall readability of the spec file, file locations/ownings fit etc. Please add license to %doc and correct your typo in Summary. As this is very minor: APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review