Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477866 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2008-12-24 11:49:34 EDT --- Review: + package builds in mock (rawhide i386). koji build= >http://koji.fedoraproject.org/koji/taskinfo?taskID=1020609 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 13e484832847e133675160862b43d933 Hardware-Verilog-Parser-0.13.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs 1..1 ok 1 + Package perl-Hardware-Verilog-Parser-0.13-1.fc11 -> Provides: perl(Hardware::Verilog::Hierarchy) = 0.03 perl(Hardware::Verilog::Parser) = 0.13 perl(Hardware::Verilog::StdLogic) = 0.03 perl(Parse::RecDescent::PrecompiledParser) perl(PrecompiledParser) Requires: /usr/bin/perl perl >= 1:5 perl(Benchmark) perl(Data::Dumper) perl(Hardware::Verilog::Hierarchy) perl(Hardware::Verilog::Parser) perl(Hardware::Verilog::StdLogic) perl(Parse::RecDescent) perl(PrecompiledParser) perl(strict) perl(vars) Suggestions:- 1) I think this package should own %{perl_vendorlib}/Hardware/ also. ==> Can be fixed by mkdir in %install as mkdir -p $RPM_BUILD_ROOT%{perl_vendorlib}/Hardware APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review