Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477867 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2008-12-24 11:48:20 EDT --- + Ok - Need Work Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1020601 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 4bdf2c5636bdc217428398eea68e44bc Perlilog-0.3.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. - duplicates in %files. + file permissions are appropriate. + make test outputs ok 1 It looks like everything is working fine! + Package perl-Perlilog-0.3-1.fc11 -> Provides: perl(PL_const) perl(PL_hardroot) perl(PL_settable) perl(Perlilog) = 0.3 perl(Perlilog::PLerror) perl(UNIVERSAL) Requires: perl >= 0:5.004 perl(Exporter) perl(Perlilog::PLerror) perl(strict) Suggestions: 1) remove following line from %files in spec %{perl_vendorlib}/* This will make sure to avoid duplicate files installation APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review