Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: psycopg2 - A PostgreSQL database adapter for Python https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199784 ------- Additional Comments From toshio@xxxxxxxxxxxxxxx 2006-08-05 15:58 EST ------- MD5Sums: f7806d7141403b062a7353341bb393b5 python-psycopg2-2.0.2-3.src.rpm 74219613b9f5b187f4e476264e2c966c psycopg2-2.0.3.tar.gz 7d692b049a1bcbc7c884eece65f98b9f python-psycopg2.spec All previous blockers have been fixed. Here's the new problems I've found: * %define ZPsycopgDAdir /var/lib/zope/Products/ZPsycopgDA/ hard codes /var. Rather than do that you should use %{_localstatedir}. * You need to own the ZPsycoDAdir in the %files section. * Since you're listing the Zope *.pyo's separate from the other files, you should ghost them just as you've ghosted the .pyo's in the main package: %ghost %{ZPsycopgDAdir}/*.pyo * The Zope subpackage should Require: zope or %{_localstatedir}/lib/zope * Using cp -p instead of just cp when installing the zope subpackage will preserve the file timestamps. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review