Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: gfs-kmod https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201077 ------- Additional Comments From panemade@xxxxxxxxx 2006-08-03 23:51 EST ------- (In reply to comment #6) > In response to Comment #2 > - Summary isn't capitalized because I was using the kernel module package > guidlines (http://fedoraproject.org/wiki/Packaging/KernelModules). The line > they show is what I'm using: > > Summary: %{kmod_name} kernel modules > If you will see other SPEC files for kernel modules then you will see its not mandatory to copy same wording written in kernel module packaging guidelines for Summary. > - Changelog has been added > - kmodtool needs to have that permission because it is script that is run from > the .spec file oops i forgot you are very correct. > - The .spec file does end in .spec, I'm not sure why this is an error. Still i think you should change SPEC file name to gfs-kmod.spec. I did that and didnt got any rpmlint error for SPEC file name. > - According to the kernel module specification, the name of the module should be > specified this way: (which it is) > Name: %{kmod_name}-kmod > > - This package will most likely never be in the mainstream kernel as it provides > support for GFS1 and we are only attempting to get GFS2 into the kernel. > - The userspace utilities are in gfs-utils, I'll get those in the proper format > according to the kernel module package guidlines. OK > > In response to comment #3 & #4 > - I've updated the kmodtool (from comment #5) this should work better now. > - Unfortunately utsrelease.h has the data that we need (#define UTS_RELEASE > "2.6.17-1.2462.fc6"), uts.h doesn't. But i found only uts.h. May be i am missing something, can you tell me what am i missing that made my system not to show utsrelease.h under installed kernel sources. > > In response to comment #5 > - I've put kmodtool back to the original, I had made modifications to get it to > work with an earlier version of the .spec file, and no longer needed those > modifications. > > New SRPM/spec are here: > http://people.redhat.com/cfeist/gfs-kmod-0.1.0-1.2.6.17_1.2505.fc6.src.rpm > http://people.redhat.com/cfeist/gfs-kernel.spec > Will check now your new package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review