Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: psycopg2 - A PostgreSQL database adapter for Python https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199784 ------- Additional Comments From devrim@xxxxxxxxxxxxxxxxx 2006-07-31 07:11 EST ------- Hi, (In reply to comment #11) > Blockers: > * Source must have a full URL. Fixed. > * Package is licensed as GPL but should be GPL with exceptions (to allow > OpenSSL and libpq [postgreSQL] linkage). I've changed it to LGPL. Is that ok? > * Why are you only installing the _psycopg.so file instead of the whole > distribution? My bad. Just a copy-paste error. I've highly modified spec file for this. > * The source package includes a Zope database adapter. Why not include it as > a subpackage? http://www.initd.org/tracker/psycopg/wiki/PsycopgTwoInstall This tells a little about the installation of Zope adapter; however I don't know where the "my_zope_instance" directory is > * Package does not build on x86_64. The %install hardcodes the directory: > lib.linux-i686-%{pyver} > Why not use setup.py install? Fixed per modifying the spec, as I wrote above. > Cosmetic: > * Since you already used "python" to extract the %{pyver} macro, there's no > need to use %{pyver} in this line: > python%{pyver} setup.py build Ok, done. > Good: <skipping> > Not yet checked: > * rpmlint I checked now, and it is clean. > * Packaging Guidelines > * Buildrequires I've removed mx and python-setuptools. mx is not needed in psycopg2. > * Requires I've removed mx from here, too. > * doc subpackage > * Directory ownership. I'll submit a new spec and srpm shortly. Regards, Devrim -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review