Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: psycopg2 - A PostgreSQL database adapter for Python https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199784 toshio@xxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |toshio@xxxxxxxxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From toshio@xxxxxxxxxxxxxxx 2006-07-29 14:03 EST ------- NEEDSWORK If you need some explanation of some of the blocker items, leave me a note here. I'll be back online tonight (~8 hours) MD5Sums: f7806d7141403b062a7353341bb393b5 python-psycopg2-2.0.2-3.src.rpm 6c056b261782c51f53ceccbf86c08749 psycopg2-2.0.2.tar.gz Blockers: * Source must have a full URL. * Package is licensed as GPL but should be GPL with exceptions (to allow OpenSSL and libpq [postgreSQL] linkage). * Why are you only installing the _psycopg.so file instead of the whole distribution? * The source package includes a Zope database adapter. Why not include it as a subpackage? * Package does not build on x86_64. The %install hardcodes the directory: lib.linux-i686-%{pyver} Why not use setup.py install? Cosmetic: * Since you already used "python" to extract the %{pyver} macro, there's no need to use %{pyver} in this line: python%{pyver} setup.py build Good: * Package is named according to the naming guidelines for python modules. * Spec name matches the package name. * Package includes a copy of the license. * The package is licensed with an Open source license. * Source matches upstream. * Source matches upstream GPG signature for: "Federico Di Gregorio <fog@xxxxxxxxx>" 06468DEB. * No locale files, therefore no need to run %find_lang. * No shared libraries for the dynamic linker to find so no ldconfig run necessary. * Package is not relocatable. * Package owns all directories it creates. * Permissions set correctly. * Package has a proper %clean. * Uses macros consistenly except for python%{pyver} note above. * Contains code, not content. * %doc files do not affect runtime. * No headers, pkgconfig files, or shared libraries so no -devel package. * Subpackages require the exact NEVR of the base package. * No .la files. * Not a GUI app so no desktop file. * Package builds on x86_64 Not yet checked: * rpmlint * Packaging Guidelines * Buildrequires * Requires * doc subpackage * Directory ownership. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review