[Bug 183439] Review Request: papyrus (Canvas drawing library based on cairo/cairomm)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: papyrus (Canvas drawing library based on cairo/cairomm)
Alias: papyrus

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183439





------- Additional Comments From paul@xxxxxxxxxxxxxxxxxxxxxx  2006-07-29 18:13 EST -------
Group:            System Environment/Libraries

Would this be not better suited to Development/Libraries? System
Environment/Libs are really for the likes of glibc et al.

Need R: cairomm

%package devel
Requires:         gtkmm24-devel >= 2.8.0 cairomm-devel >= 0.6.0 pkgconfig
doxygen graphviz

Once installed, do rpm -qa --requires <package-name>. This will give you the
requires for main and devel packages to run correctly. I seriously doubt it will
need anything past cairomm-devel

%install

%{__cp} -arv docs/reference .
%{__cp} -arv docs/gallery .

Should these not be included in the %docs part of %files? If they're not, where
are they supposed to be getting copied to? Are the permissions being kept correctly?

%files
%{_libdir}/lib*.so.*

Niggle. How many libraries are being installed? If it's one, just expand it.
This makes reading the spec for us poor reviewers much simpler. If it's a pile
which can be globbed together, then %{_libdir}/libpap*.so.* is also okay.

%files devel
%{_bindir}/*-demo

I'd strongly recommend naming this

%doc ChangeLog reference gallery

This is confusing me. You've already copied reference and gallary somewhere -
why have you got this?





-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]