Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: 915resolution https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194566 ------- Additional Comments From cweyl@xxxxxxxxxxxxxxx 2006-07-27 19:45 EST ------- (In reply to comment #7) > Is the .fc5 at the end of the src.rpm your own rename? if it is, please don't. > src rpms are release agnostic. I define %dist in my ~/.rpmmacros file, for my own sanity when building packages... It's not a rename. > The spec file still has the release as 0?{%dist}. This should be 2 as it's the > 2nd release made. Remove the 0/-1 comment, it's wrong! Hit reload on your browser, it's out there at 1 :) > You don't need the make clean (unless the source tarball has a pre-made > configure with pre-made bits and pieces) in %build It does :) > I'd prefer install -m 755 for the package into %{_sbindir}. Also, as it's only > one program going into %{_sbindir}, give it the name in %files Are these personal preferences, or do you consider them blockers? > The changelog hasn't altered. Each time you change something, it gets > documented, so it should read [...snip...] > (you get the idea) Again, hit reload... :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review