Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: 915resolution https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194566 ------- Additional Comments From paul@xxxxxxxxxxxxxxxxxxxxxx 2006-07-27 19:31 EST ------- Is the .fc5 at the end of the src.rpm your own rename? if it is, please don't. src rpms are release agnostic. The spec file still has the release as 0?{%dist}. This should be 2 as it's the 2nd release made. Remove the 0/-1 comment, it's wrong! You don't need the make clean (unless the source tarball has a pre-made configure with pre-made bits and pieces) in %build I'd prefer install -m 755 for the package into %{_sbindir}. Also, as it's only one program going into %{_sbindir}, give it the name in %files The changelog hasn't altered. Each time you change something, it gets documented, so it should read %changelog * Mon 25 Dec 2006 Paul F. Johnson <paul@xxxxxxxxxxxxxxxxxxxxxx> 0.5-2 - fixed silly mistake in the spec file - added ia64 and sparcx86 patches * Sun 24 Dec 2006 Paul F. Johnson <paul@xxxxxxxxxxxxxxxxxxxxxx> 0.5-1 - added BR foo - removed R bar - added a b c and d into docs - chmod 0755 sbindir-foobar - bumped to new version * Sun 17 Dec 2006 Paul F. Johnson <paul@xxxxxxxxxxxxxxxxxxxxxx> 0.4-11 (you get the idea) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review