Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Asuka https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199919 ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-07-27 07:21 EST ------- Not a full review yet, first a few must fix items: * You're using a hardcoded UID, very very BAD! Instead try this in a %pre script groupadd -r irc || : useradd -r -g irc -d /etc/ircd -n -c "IRC Daemon" irc || : * Since this program will leave log files around after erase do not remove the user and group on uninstall otherwise we get files owned by a non existing user which is bad security wise * "irc" as username and /etc/ircd as dir are way to generic and likely to collide with other packages, try asuka as username and /etc/asuka as dir. * The same goes for the init and logrotate script names * You're manually creating a %doc, thats not nescesarry add this to %prep: cp tools/README doc/README.mkpasswd and add "%doc doc/*" to %files then the dir will get created and the files copied there by RPM. Please post a new version with this fixed and taking the comments above into account, then I'll do a full review. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review