Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Asuka https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199919 ------- Additional Comments From panemade@xxxxxxxxx 2006-07-25 06:15 EST ------- *Remember above SPEC contains REAME in %doc tag *I dont know how to install README to REDME.mkpasswd with %doc under %files *Again Binary RPM reported some more rpmlint errors as W: asuka wrong-file-end-of-line-encoding /usr/share/doc/asuka-1.2.1/snomask.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. ==> remove non-unix characters by saving file under Linux W: asuka wrong-file-end-of-line-encoding /usr/share/doc/asuka-1.2.1/p10.txt This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. ==> remove non-unix characters by saving file under Linux E: asuka incoherent-logrotate-file /etc/logrotate.d/ircd Your logrotate file should be named /etc/logrotate.d/<package name>. ==>rpmlint suggests to use same logrotate filename as package name W: asuka non-conffile-in-etc /etc/logrotate.d/ircd A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. ==>you included %config %{_sysconfdir}/ircd chnage it to %config(noreplace) %{_sysconfdir}/ircd W: asuka dangerous-command-in-%post chown W: asuka dangerous-command-in-%postun userdel ==> Maybe Paul would like to comment here E: asuka no-chkconfig-line /etc/rc.d/init.d/ircd The init script doesn't contain a chkconfig line to specify the runlevels at which to start and stop it. ==>don't know why rpmlint gave error besides chkconfig is included in asuka-init W: asuka incoherent-init-script-name ircd The init script name should be the same as the package name in lower case. ==>as per rpmlint suggestions init-script-name must be same as package name in lower case. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review